Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for accepting and cancelling friend invites #849

Merged
merged 3 commits into from
Nov 21, 2021

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Oct 25, 2021

Description

  • Adds a new object MyPlexInvite which is separate from MyPlexUser.
  • Adds methods to retrieve sent and received invites MyPlexAccount.pendingInvites() and MyPlexAccount.pendingInvite(user) which return MyPlexInvite objects.
  • Adds methods to accept a friend invite MyPlexAccount.acceptInvite(user) and cancel a friend invite MyPlexAccount.cancelInvite(user).

Breaking change:

  • Pending invites are no longer listed along with MyPlexAccount.users(). Use MyPlexAccount.invites() instead.

Fixes #767

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit 777ea75 into pkkid:master Nov 21, 2021
@JonnyWong16 JonnyWong16 deleted the feature/myplexInvites branch November 21, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removing a friend when they haven' accepted an invite, fails.
1 participant