Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PMS timeline reporting on clients when using playMedia #826

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

jjlawren
Copy link
Collaborator

@jjlawren jjlawren commented Sep 11, 2021

Description

Add missing parameters to the player playMedia command.

This fixes an issue where some AndroidTV (e.g., Nvidia Shield and Fire TV), Samsung (Tizen), LG WebOS, and likely other clients do not report timeline updates to PMS when playback is started using plexapi. This would cause active playback sessions to not show up in the Plex Web dashboard (and PlexServer.sessions()), watched states to not update, etc.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@jjlawren jjlawren changed the title Fix PMS timeline reporting on AndroidTV clients when using playMedia Fix PMS timeline reporting on clients when using playMedia Sep 13, 2021
@jjlawren jjlawren merged commit 69739d6 into pkkid:master Sep 13, 2021
@jjlawren jjlawren deleted the fix_playMedia_for_android branch September 13, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants