Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple resource address sorting from connection attempts #800

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

jjlawren
Copy link
Collaborator

Description

Previously the connection address priority order for resources was hardcoded to prefer local over remote and HTTPS over HTTP in the MyPlexResource.connect() method. This decouples the generation of the prioritized list which:

  1. Gives users access to the generated list of ordered connections.
  2. Allows modification of the priorities.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@jjlawren jjlawren merged commit 3b1dce7 into pkkid:master Jul 27, 2021
@jjlawren jjlawren deleted the decouple_resource_address_ordering branch July 27, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants