Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use FilterChoice and FilteringSort objects in library search #788

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

JonnyWong16
Copy link
Collaborator

Description

  • Adds ability to use a FilterChoice object when searching a library using a tag.
availableChoices = library.listFilterChoices('collection')  # List of FilterChoice objects
filters = {'collection': availableChoices[0]}  # Filter using a FilterChoice object instead of a collection name string
library.search(filters=filters)
  • Adds ability to use a FilteringSort object when searching a library using a sort field. Using a FilteringSort object will sort in the defaultDirection of the field.
availableSorts = library.listSorts()  # List of FilteringSort objects.
sort = availableSorts[0]  # Sort using a FilteringSort object instead of a field:dir string
library.search(sort=sort)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit 456a8a5 into pkkid:master Jul 16, 2021
@JonnyWong16 JonnyWong16 deleted the feature/search_objects branch October 4, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant