Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add episodeNumber, trackNumber, and hasPreviewThumbnails helper properties #746

Merged
merged 5 commits into from
May 24, 2021

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented May 11, 2021

Description

Adds the following helper properties:

  • Episode.episodeNumber alias to index
  • Track.trackNumber alias to index
  • MediaPart.hasPreviewThumbnails helper for MediaPart.indexes == "sd"
  • Movie.hasPreviewThumbnails and Episode.hasPreviewThumbnails helper if any MediaPart.hasPreviewThumbnails is True

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 changed the title Add episodeNumber, trackNumber, and hasPreviewThumbnail helper properties Add episodeNumber, trackNumber, and hasPreviewThumbnails helper properties May 20, 2021
@JonnyWong16 JonnyWong16 merged commit c4522d9 into pkkid:master May 24, 2021
@JonnyWong16 JonnyWong16 deleted the feature/properties branch June 7, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant