Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing key when PlayQueue passed to playMedia #692

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

jjlawren
Copy link
Collaborator

If a PlayQueue object is passed to PlexClient.playMedia(), the generated key argument used in the resulting call is always None. This uses the currently selected item from the PlayQueue in that case.

@jjlawren
Copy link
Collaborator Author

An alternative that's less explicit but far simpler: jjlawren@bb7b959

@jjlawren
Copy link
Collaborator Author

The key value has been sending None to clients for years when a premade playqueue is passed in, but most seem to handle it gracefully and play anyway. Others like the 3rd party Samsung TV "Orca" client do not and throw up an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant