Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix season watched/unwatched #678

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix season watched/unwatched #678

merged 2 commits into from
Mar 2, 2021

Conversation

JonnyWong16
Copy link
Collaborator

Description

Fixes the filter for Season.watched() and Season.unwatched() to use viewCount to return the correct list of episodes. Also added tests for those two methods.

Fixes #677

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Hellowlol Hellowlol merged commit f9a09ae into pkkid:master Mar 2, 2021
This was referenced Mar 12, 2021
Closed
Closed
Closed
@JonnyWong16 JonnyWong16 deleted the bugfix/season_watched branch May 13, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect output from season.watched() and season.unwatched()
2 participants
@JonnyWong16 @Hellowlol