-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update media type attributes #630
Merged
Hellowlol
merged 28 commits into
pkkid:master
from
JonnyWong16:feature/media_attributes
Dec 31, 2020
Merged
Update media type attributes #630
Hellowlol
merged 28 commits into
pkkid:master
from
JonnyWong16:feature/media_attributes
Dec 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonnyWong16
force-pushed
the
feature/media_attributes
branch
from
December 24, 2020 00:56
c125645
to
22bfeb0
Compare
JonnyWong16
force-pushed
the
feature/media_attributes
branch
from
December 24, 2020 06:00
8e462bf
to
8206dfb
Compare
Hellowlol
reviewed
Dec 24, 2020
Hellowlol
reviewed
Dec 24, 2020
@JonnyWong16 I’ll merge when I can rebase this. On mobile atm. |
It was some failing tests. Ill need to manually check these before i merge |
Just try re-running it. |
keep compat for season(int)
JonnyWong16
commented
Dec 30, 2020
JonnyWong16
commented
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is mostly for bringing forward the attribute changes I made to the media type object from my
3.6.0-tautulli
fork. It also unifies the methods between all the media type objects.Attribute changes:
Audio
,Artist
,Album
, andTrack
attributes.Video
,Movie
,Show
,Season
,Episode
, andClip
attributes.Photoalbum
, andPhoto
attributes.Collection
attributes.Playlist
attributes.New objects:
media.Style
tag object.New methods:
Track.locations
common property to get themedia.Part
locations of the track.Clip.locations
common property to get themedia.Part
locations of the clip.Photo.locations
common property to get themedia.Part
locations of the photo.Photoalbum.clip(title)
method to return a clip in a photo album matching thetitle
.Photoalbum.clips()
method to return all clips in a photo album.Photoalbum.get()
alias toPhotoalbum.photo()
.Collection.item(title)
method to return an item in a collection matching thetitle
.Collection.get()
alias toCollection.item()
.Playlist.item(title)
method to return an item in a playlist matching thetitle
.Playlist.get()
alias toPlaylist.item()
.Method changes:
title
andseason
parameter inShow.season()
.album
name andtrack
number parameters inArtist.track()
.track
number parameter inAlbum.track()
.Breaking changes:
index
,parentIndex
,grandparentIndex
andratingKey
,parentRatingKey
,grandparentRatingKey
attributes were typestr
and have now all been casted toint
for consistency.collections
attribute is removed fromEpisode
since you cannot add an episode to a collection.titleSort
attributes now default totitle
instead of returning a blank string.TheKept check fortitle
parameter inShow.season()
used to accept an integer for the season number which is now changed to theseason
parameter.isinstance(title, int)
for backwards compatibility.Type of change
Please delete options that are not relevant.
Checklist: