Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LibrarySection collections method to plural and add playlists method #617

Merged

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Dec 4, 2020

Description

This changes the LibrarySection.collections() method to plural to be consistent with the other methods such as Show.seasons(), Season.episodes(), etc. A DeprecationWarning is added to the old collection() method. A NotImplementedError is raised for PhotoSection.collections().

It also adds a LibrarySection.playlists() method to retrieve all playlists in a library.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

* Add DeprecationWarning to old collection method
* Add NotImplementedError for PhotoSection.collections()
@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #617 (422f82e) into master (f422905) will increase coverage by 0.05%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   65.76%   65.81%   +0.05%     
==========================================
  Files          20       20              
  Lines        4118     4125       +7     
==========================================
+ Hits         2708     2715       +7     
  Misses       1410     1410              
Impacted Files Coverage Δ
plexapi/library.py 78.82% <69.23%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f422905...422f82e. Read the comment docs.

@Hellowlol Hellowlol merged commit 16a63f1 into pkkid:master Dec 5, 2020
@JonnyWong16 JonnyWong16 deleted the feature/library_collections_playlists branch May 13, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants