-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Improvements #598
Closed
Closed
Search Improvements #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow for libtype.categoryOperator searching (episode.viewCount>>2) allow for categoryOperator searching (viewCount>>2) test for available operators for used category test for booleanFilters values to be str or int variants of 1 or 0
Draft until I can add some tests. Tests should include comparing library searching against inverse searching found in #595. |
This was referenced Nov 17, 2020
Closed
addresses #622 in the case of searching for a "libType.filter" like "show.label" libCategory would be the filter "label" if the search kwarg is not "libType.filter" and just "filter" libCategory is the filter
Just some examples of what will work now with the current state of this PR: library = plex.library.section('TV Shows')
library.search(unwatchedLeaves=True) # resolves to search show.unwatchedLeaves
library.searchShows(unwatched=True) # resolves to search episode.unwatched
library.search(unwatched=True) # resolves to search episode.unwatched
library.search(**{'episode.unwatchedLeaves':True}) # resolves to episode.unwatchedLeaves and errors as this pairing does not exist |
Adding additional checks for libtype.category in kwargs or using searchLibtype Attempt to resolve to the correct pairing of libtype.category Provide detail messaging when a category exists in multiple libtypes in the library
this commit addresses this issue
any update to when this might get finished? Not trying to rush you just got curious when i saw it still wasn't in the latest release |
fix confirmed working in previous stable version
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving the functionality of
librar.search()
to work more inline with Plex's webUI.Searching now allows the libtype.category searching found in libraries that have grandparent, parent, and child structures.
Searching now allows for the use of operators (>>, <<, !, <, >)
Addresses issues #392, #320, #595
Newly supported searches:
Type of change
Please delete options that are not relevant.
Checklist: