Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced friends route with v2 counter-part #1413

Merged
merged 1 commit into from
May 18, 2024

Conversation

JamsRepos
Copy link
Contributor

Description

Plex has decided to deprecate the old route from the v1 API, this replaces it with it's v2 counter-part.

Fixes #1412

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JamsRepos JamsRepos changed the title Critical Route Fix Replaced friends route with v2 counter-part May 7, 2024
@JamsRepos
Copy link
Contributor Author

Do note; I have tested this in both put and delete cases.

@OriginsTV
Copy link

where is that v2 API i cant found it thanks bro for your help

@JamsRepos
Copy link
Contributor Author

where is that v2 API i cant found it thanks bro for your help

Not quite sure what you mean? You find this endpoint by performing the action on the browser then checking which API call is called.

@mtrogman
Copy link

mtrogman commented May 10, 2024

where is that v2 API i cant found it thanks bro for your help

Not quite sure what you mean? You find this endpoint by performing the action on the browser then checking which API call is called.

I assume he is asking if they have a website that lists off their APIs so that you do not have to make the call and inspect via browser.

Which I have looked as well and plex doesn't publicly post their API documentation (weak)

@JamsRepos
Copy link
Contributor Author

Yeah, Plex does not disclose their API or their changes for it. So it's just a case of waiting for them to deprecate it hence this PR.

@JonnyWong16
Copy link
Collaborator

Where do you see https://plex.tv/api/v2/sharings/<userId>?

I see these two URLs when editing shared libraries/restrictions for another user in Plex Web.

  • https://clients.plex.tv/api/v2/shared_servers/<sharedServerId>
  • https://clients.plex.tv/api/v2/sharing_settings

@JamsRepos
Copy link
Contributor Author

Where do you see https://plex.tv/api/v2/sharings/<userId>?

I see these two URLs when editing shared libraries/restrictions for another user in Plex Web.

* `https://clients.plex.tv/api/v2/shared_servers/<sharedServerId>`

* `https://clients.plex.tv/api/v2/sharing_settings`

Remove a user from your server and you'll get the sharings endpoint. I then tried to update a user and the endpoint also worked there too.

May require additional testing now though as for the most part I've forgotten.

@mtrogman
Copy link

Good Afternoon,
Is there any further validation or requirements to get this PR merged? I can happily help as this broke automation I have in place and I would love to get this working again.

@JonnyWong16
Copy link
Collaborator

I am merging this but only indicating that it is a temporary fix.

The URL used here does not match what Plex Web is using for update shared libraries/restrictions. So it is uncertain whether this is actually intended/supported and it may break again at any moment.

@JonnyWong16 JonnyWong16 merged commit 5e6db51 into pkkid:master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with DELETE USER
4 participants