Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: pass existing filters for albums method of Artist #1347

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

Dr-Blank
Copy link
Contributor

@Dr-Blank Dr-Blank commented Jan 24, 2024

Description

if a filters kwarg was passed, it would raise error that duplicate keyword recieved. this fixes that edge case
TypeError: search() got multiple values for keyword argument 'filters'

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Dr-Blank Dr-Blank force-pushed the fix/carry-over-filters branch from cd03099 to 119dc36 Compare January 24, 2024 18:48
@Dr-Blank Dr-Blank changed the title bugfix: pass existing filters for album(s) method of Artist bugfix: pass existing filters for albums method of Artist Jan 24, 2024
@JonnyWong16 JonnyWong16 merged commit fe648f6 into pkkid:master Feb 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants