Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default 4k chunk size (powers of 2) for download #1326

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 28, 2023

Description

Added as 4096 as probably changing from 1024 in 7e9bd51

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@glensc glensc changed the title Use 4k chunk size (powers of 2) for download Use default 4k chunk size (powers of 2) for download Dec 28, 2023
@JonnyWong16 JonnyWong16 merged commit 8bb9f5f into pkkid:master Feb 4, 2024
5 checks passed
@glensc glensc deleted the patch-2 branch February 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants