Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genres attribute to Track #1318

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Add genres attribute to Track #1318

merged 4 commits into from
Feb 17, 2024

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Dec 22, 2023 •
edited
Loading

Description

Adds genres attribute to Track.

Requires: Plex Media Server 1.40.0
https://forums.plex.tv/t/plex-media-server/30447/609

Closes #1321.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 mentioned this pull request Dec 26, 2023
Closed
@JonnyWong16
Copy link
Collaborator Author

Todo: Add GenreMixin to Track.

blacktwin
blacktwin approved these changes Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@blacktwin blacktwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackctra added a commit to jackctra/python-plexapi-test that referenced this pull request Feb 17, 2024
@jackctra
added genres attribute to track pkkid#1318
70924f5
@JonnyWong16 JonnyWong16 merged commit 284a577 into pkkid:master Feb 17, 2024
5 checks passed
@JonnyWong16 JonnyWong16 deleted the feature/track_genres branch March 31, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacktwin blacktwin blacktwin approved these changes

Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for track genres in music libraries
2 participants
@JonnyWong16 @blacktwin