download() with kwargs clobbers multiple parts/media

[montaguethomas]

Describe the Bug

The download() method on PlexObject class when passed kwargs will use getStreamURL() method. However it is called exactly the same for each Media Part that is being looped over.

python-plexapi/plexapi/base.py

Line 869 in dd80deb

download_url = self.getStreamURL(**kwargs)

This results in generating transcode urls for the same media and part index multiple times, which default to 0 and not defined in the kwargs passed to getStreamURL().

python-plexapi/plexapi/base.py

Lines 779 to 780 in dd80deb

	'mediaIndex': kwargs.pop('mediaIndex', 0),
	'partIndex': kwargs.pop('mediaIndex', 0),

Code Snippets

No response

Expected Behavior

download() method's parts loop should set mediaIndex and partIndex when calling getStreamURL() in order to return different transcoding urls.

Additional Context

This is still affected by the #1208 issue where downloaded file names could clobber the file written to disk.

Operating System and Version

All

Plex Media Server Version

All

Python Version

All

PlexAPI Version

2.x