Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extending eumetsat api #10

Merged
merged 16 commits into from
Dec 15, 2024
Merged

extending eumetsat api #10

merged 16 commits into from
Dec 15, 2024

Conversation

BengtRydberg
Copy link
Collaborator

@BengtRydberg BengtRydberg commented Dec 10, 2024 •
edited
Loading

I think the EumetsatAPI class will be a bit more useful if we "extend" it as suggested in this draft PR or something similar.
I have added the handling

  • of fetching data from three more datasets (AMSU, AVHRR, MHS) from Metops (polar orbiting satellites)
  • of providing a bounding box (polygon vertices) as a query filter
  • of tailoring and fetching the search results to a desired output (i.e. netcdf formatted files covering a given bounding box)

@pkhalaj do you think what I started looks ok? We can discuss it on Thursday when I visit you.

@pkhalaj
Copy link
Owner

pkhalaj commented Dec 10, 2024

Work in progress.

I think the EumetsatAPI class will be a bit more useful if we "extend" it as suggested in this draft PR or something similar.

@pkhalaj do you think what I started looks ok? We can discuss it on Thursday when I visit you.

Totally agree! Let's discuss this further. 👍

@pkhalaj
Copy link
Owner

pkhalaj commented Dec 11, 2024

@BengtRydberg
Could you please rebase your proposed changes against the updated main branch?
Thank you.

@BengtRydberg
Copy link
Collaborator Author

Work in progress.
I think the EumetsatAPI class will be a bit more useful if we "extend" it as suggested in this draft PR or something similar.
@pkhalaj do you think what I started looks ok? We can discuss it on Thursday when I visit you.

Totally agree! Let's discuss this further. 👍

I have rebased and extended my PR description above so it is a bit more clear what the aim with this PR is.

@BengtRydberg BengtRydberg marked this pull request as ready for review December 12, 2024 19:11
@pkhalaj pkhalaj self-requested a review December 13, 2024 08:02
@pkhalaj pkhalaj added the enhancement New feature or request label Dec 13, 2024
pkhalaj
pkhalaj approved these changes Dec 13, 2024
View reviewed changes
Copy link
Owner

@pkhalaj pkhalaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did some minor styling and naming improvements.

Otherwise looks good to me! 👍

@pkhalaj
Remove SearchResults as the type of the search_results parameter …
ef121bb 
…in `fetch_products()`

This is to resolve the issue when making the documentation!
@pkhalaj pkhalaj merged commit 402bf99 into pkhalaj:main Dec 15, 2024
2 checks passed
@pkhalaj pkhalaj deleted the extend_eumetsat_api branch December 15, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkhalaj pkhalaj pkhalaj approved these changes

Assignees

@pkhalaj pkhalaj

@BengtRydberg BengtRydberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BengtRydberg @pkhalaj