we need to set exefiles ids on darwin

otherwise we get link failures for some build scripts later if id is eg @rpath/foo.dylib
pkgxdev · Aug 23, 2022 · 8b824a2 · 8b824a2
1 parent e786aa2
commit 8b824a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@ Change how your team works.
 &nbsp;
 
 
-# tea/cli 0.4.2
+# tea/cli 0.4.3
 
 tea is a universal virtual‑environment manager:
 

diff --git a/src/prefab/build.ts b/src/prefab/build.ts
@@ -135,6 +135,10 @@ async function set_rpaths(exename: Path, pkgs: PackageRequirement[]) {
       return [
         "install_name_tool",
         ...our_rpaths.flatMap(rpath => ["-add_rpath", rpath]),
+        // we can't trust the id the build system picked
+        // we need dependents to correctly link to this dylib
+        // and they often use the `id` to do so
+        "-id", exename,
         exename
       ]
     case 'windows':
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ Change how your team works. @@
     &nbsp;
-    # tea/cli 0.4.2
+    # tea/cli 0.4.3
     tea is a universal virtual‑environment manager:
@@ Expand Down @@