Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dialog event Coverity warnings #3846

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fixed dialog event Coverity warnings #3846

merged 2 commits into from
Jan 30, 2024

Conversation

sauwming
Copy link
Member

Re #3754 , Coverity yields a couple of warnings:

>>>     CID 1533986:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "dlgev->status" without holding lock "pj_mutex_t.mutex". Elsewhere, "pjsip_dlg_event.status" is written to with "pj_mutex_t.mutex" held 1 out of 1 times.
567             for (i=0; i<dlgev->status.info_cnt; ++i) {
568                 dlgev->[status.info](http://status.info/)[i].dialog_node = NULL;
353             info->dialog_info_state.ptr = info->buf_ + total;
>>>     CID 1533985:    (OVERRUN)
>>>     Overrunning array of 1024 bytes at byte offset 1024 by dereferencing pointer "info->dialog_info_state.ptr".

@sauwming sauwming merged commit e12a8d1 into master Jan 30, 2024
33 of 35 checks passed
@sauwming sauwming deleted the dlg-ev-coverity branch January 30, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants