-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update video handling in Android PJSUA2/SWIG sample apps #3673
Conversation
…ain aspect ratio, add video capability in Kotlin sample app, etc).
Bitrise fails to build, although it shows 404 everytime I click on it. I tried to build the sample app locally and got a few build errors, such as:
|
Strange, it did not happen here, just retried on both Android Studio & SWIG Just in case,
And
Could you check them on yours? |
Also the desktop CI Actions should also build the SWIG bindings including Java? |
Ah, thanks for the pointer, there are conflicting definition on my workdir here, which doesn't get cleaned by make clean or realclean, so I remove it manually:
The next problem I encountered is: Everything works fine here now. |
@@ -373,6 +408,9 @@ public void init(MyAppObserver obs, String app_dir, | |||
System.out.println(e); | |||
} | |||
|
|||
// TCP & TLS transports with default SIP ports | |||
// sometimes not working fine on Android somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on my device, so I have to uncomment it here.
Perhaps you can try using non-default ports rather than disabling this entirely?
Re: gradle version. Not sure which gradle version should be used here, there are too many, checked the web it looks like the latest is 8.3, so 7.x actually sounds rather old already. Considering Android Studio is a bit aggressive in suggesting updates, I guess updating IDE/SDK/tools versions is like a daily routine for proper Android developers (definitely not me :D) |
Everything looks okay to me, but the bitrise failure will need to be fixed. |
The update includes: