-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed native iOS preview issue #3350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanangizz
approved these changes
Feb 15, 2023
trengginas
approved these changes
Feb 22, 2023
sauwming
added a commit
that referenced
this pull request
Jul 5, 2023
dshamaev-intermedia
pushed a commit
to intermedia-net/pjproject
that referenced
this pull request
Sep 4, 2023
(cherry picked from commit f1e6313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of issues with iOS native video preview:
PJMEDIA_VID_DEV_CAP_INPUT_PREVIEW
while the remote video is obtained usingPJMEDIA_VID_DEV_CAP_OUTPUT_WINDOW
as before.The sample app ipjsua will be updated to give an example on how to display the local preview.
Note that the issue should not affect applications that use OpenGL renderer (which is the default) instead of UIView, or if they do not use the native preview feature.