Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed native iOS preview issue #3350

Merged
merged 7 commits into from
Feb 22, 2023
Merged

Fixed native iOS preview issue #3350

merged 7 commits into from
Feb 22, 2023

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Feb 1, 2023

Fixed a couple of issues with iOS native video preview:

  1. Currently the iOS native preview will be added to the renderer view, which may cause a combined display between local preview and remote video. With the patch, native preview and renderer view will be separated. The native preview view can be obtained using the capability PJMEDIA_VID_DEV_CAP_INPUT_PREVIEW while the remote video is obtained using PJMEDIA_VID_DEV_CAP_OUTPUT_WINDOW as before.
  2. Fixed a bug in pjsua_vid which will still connect local preview to the renderer slot even if the preview is native, which also causes mixed display. And since the mixing is done by video conference, the result is inseparable (while for the issue 1, you can still extract the layers with some effort).

The sample app ipjsua will be updated to give an example on how to display the local preview.

Note that the issue should not affect applications that use OpenGL renderer (which is the default) instead of UIView, or if they do not use the native preview feature.

@sauwming sauwming merged commit 433ddab into master Feb 22, 2023
@sauwming sauwming deleted the ios-preview branch February 22, 2023 05:04
sauwming added a commit that referenced this pull request Jul 5, 2023
@sauwming sauwming modified the milestones: release-2.14, release-2.13.1 Jul 5, 2023
dshamaev-intermedia pushed a commit to intermedia-net/pjproject that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在2.13 使用视频通话,打电话预览视频变形,展示模糊
3 participants