Add support for user count over time #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge in new changes
|
@pjcalvo FYI |
pjcalvo
requested changes
Feb 27, 2023
|
Hey thanks for doing this PR. A couple of things: The change on the dashboard json is way to big to review. Can u put that on a separate PR, add a more descriptive explanation or attach some screenshots. Also please remove the increase version. I will increase the version manually when creating a new release tag. Thanksm |
|
Done! No problem, happy to contribute. |
|
@pjcalvo Looking for another review here |
pjcalvo
approved these changes
Mar 8, 2023
|
Thanks, sorry it took me a while to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds the "user_count" field to all locust requests