Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added delete form feature #238

Closed
wants to merge 1 commit into from

Conversation

swaraj344
Copy link

What does this PR do?

Added feature to delete form with confirmation.

Fixes #205

Loom Video: https://www.loom.com/share/b2cf9605e4a147ed9b60c764d755d7a3

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshot 2023-10-22 202445

How should this be tested?

Important

This PR Depend on this
piyushgarg-dev/review-app-api#61
this Should be merge before

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Thank you for following the naming conventions! 🙏

@swaraj344 swaraj344 changed the title added delete form feature [Feat]: added delete form feature Oct 22, 2023
@swaraj344 swaraj344 changed the title [Feat]: added delete form feature feat: added delete form feature Oct 22, 2023
@github-actions
Copy link

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict Merge Conflict label Oct 23, 2023
@hemantwasthere
Copy link
Collaborator

Closing this PR cuz I have already added a delete form modal!

Thanks for your contributions 💙🚀

@hemantwasthere
Copy link
Collaborator

And will later add the functionality of the delete form once it is tested and implemented in the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 merge conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Form delete feature
3 participants