Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ESLint for code quality improvements #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vikrantsingh22
Copy link

@Vikrantsingh22 Vikrantsingh22 commented Oct 9, 2023

PR: Add-ESLint-for-code-quality-improvements

Addressed: #38

Description:
This pull request addresses the need for ESLint configuration within our open-source project to enhance code quality and maintainability. I have taken the following steps to implement ESLint for TypeScript:

  • Configured ESLint for TypeScript.
  • Added necessary ESLint plugins.
  • Created the .eslintrc.js configuration file.
  • Added a .eslintignore file to exclude specific files or directories from linting.
  • Included a script for running ESLint using yarn run lint.
  • Added a TypeScript type-checking script with yarn run check-types (executing tsc -p tsconfig.json --noEmit).

Purpose:
The primary goal of this pull request is to enforce consistent code style and identify potential issues in the codebase, such as unused variables and other common programming mistakes. This will help maintain code quality and improve collaboration among contributors.

Checklist:

  • All code follows ESLint rules and TypeScript guidelines.
  • The ESLint configuration is well-documented in the .eslintrc.js file.
  • I have tested the yarn run lint and yarn run check-types scripts, and they are functioning as expected.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thank you for following the naming conventions! 🙏

@Vikrantsingh22 Vikrantsingh22 changed the title feat(eslint):Add-ESLint-for-code-quality-improvements feat: Add ESLint for code quality improvements Oct 9, 2023
@Vikrantsingh22
Copy link
Author

please review this pull request for me @hemantwasthere @Chaitanya-Shahare

@github-actions github-actions bot added the 🚨 merge conflict Merge Conflict label Oct 29, 2023
@Vikrantsingh22
Copy link
Author

I have made the required changes to resolve conflict merge @piyushgarg-dev @hemantwasthere @Ram-tyagi @ManishPJha

@github-actions github-actions bot removed the 🚨 merge conflict Merge Conflict label Oct 31, 2023
@Vikrantsingh22
Copy link
Author

Vikrantsingh22 commented Oct 31, 2023

The merge conflict is resolved and the label is also removed but pr hasn't being merged kindly merge my PR.
The hacktoberfest will end in 5 hours
@piyushgarg-dev @hemantwasthere @Ram-tyagi @MeenuyD @cybertron15 @saadabban76 @ManishPJha @Chaitanya-Shahare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant