add storyshots #388
Merged
add storyshots #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit e6dba9f): https://pixiv-charcoal-web--pr388-feat-storyshots-w6deqoqx.web.app (expires Mon, 06 Nov 2023 12:53:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
|
Size Change: -246 B (0%) Total Size: 585 kB
ℹ️ View Unchanged
|
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
commented
Sep 27, 2023
Comment on lines
+108
to
+110
| "resolutions": { | ||
| "react-test-renderer": "17.0.2" | ||
| } |
There was a problem hiding this comment.
storyshot v7 からは内部で react-test-renderer 18 系を使用するようになっていて charcoal の react 17 との組み合わせでエラーをはいていたのですべての react-test-renderer の version を 17.0.2 で固定した
naporin0624
commented
Sep 27, 2023
Comment on lines
+20
to
+23
| jest.mock('@react-aria/utils', () => ({ | ||
| ...jest.requireActual('@react-aria/utils'), | ||
| useId: () => 'test-id', | ||
| })) |
There was a problem hiding this comment.
react-aria/utils の useId が実行ごとに代わるので mock
naporin0624
commented
Sep 27, 2023
| }, | ||
| moduleNameMapper: { | ||
| ...defaultConfig.moduleNameMapper, | ||
| '^@charcoal-ui/(.*)$': '<rootDir>/packages/$1/src', |
There was a problem hiding this comment.
storyshot を monorepo root で実行してる環境上 @charcoal-ui の path 解決を jest.config.mjs にあるものとは異なるものを指定したかったので別ファイルにした
toshusai
approved these changes
Oct 4, 2023
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
|
めちゃくちゃ mdx 周りで error をはいているのでそれの対応をする |
この辺で死んでる |
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
2 の内容find packages -type f -name "*.mdx" | while read -r file; do
mv "$file" "${file%.mdx}.stories.mdx"
doneimport { transform } from '@babel/core';
import { compileSync } from "@mdx-js/mdx";
export default {
process(src, filename) {
const code = compileSync(src);
const result = transform(code, {
presets: [['@babel/preset-react', { runtime: 'automatic' }]],
filename,
});
return result.code;
},
} transform: {
+ '^.+\\.mdx?$': '<rootDir>/.storybook/transform.mjs',
...defaultConfig.transform,
- '^.+\\.mdx?$': '@storybook/addon-docs/jest-transform-mdx',
},2 で動作させるために mdx 拡張子によるエラー内容 Error: Cannot index \`.mdx\` file (\`./packages/tailwind-config/src/docs/borderRadius/index.mdx\`) in \`storyStoreV7: false\` mode.
The legacy story store does not support new-style \`.mdx\` files. If the file above
is not intended to be indexed (i.e. displayed as an entry in the sidebar), either
exclude it from your \`stories\` glob, or add <Meta isTemplate /> to it.
If you wanted to index the file, you'll need to name it \`stories.mdx\` and stick to the
legacy (6.x) MDX API, or use the new store.https://github.com/pixiv/charcoal/pull/401/files#diff-586e4931b7ba3fab6fb8707cf12ddc51f1b9b4a8b80eeacea9e106f9f6796ad3 で意図的に かなり数が少なかったのですが mdx って消していく予定ってありますか？ storyshots 的には抜かれていると嬉しい気がします。 |
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません
備考
.story.mdxから.stories.mdxに変更した