Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn の PnP モードを試す #240

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
cd35ebd
chore: remove node_modules linker
fsubal Feb 23, 2023
fd5dd1a
chore: yarn dlx @yarnpkg/sdks vscode
fsubal Feb 23, 2023
78b2d14
chore: commit .pnp.cjs
fsubal Feb 23, 2023
5e1792f
chore: upgrade yarn
fsubal Feb 23, 2023
7ebbd28
chore: upgrade typescript
fsubal Feb 23, 2023
9571fcf
chore: remove node_modules linker
fsubal Feb 23, 2023
5f4396d
chore: yarn dlx @yarnpkg/sdks vscode
fsubal Feb 23, 2023
cf3490d
chore: commit .pnp.cjs
fsubal Feb 23, 2023
bdc5380
chore: upgrade yarn
fsubal Feb 23, 2023
c9e6581
chore: upgrade typescript
fsubal Feb 23, 2023
187e0d2
chore: add @types
fsubal Feb 24, 2023
004764a
chore: yarn dedupe
fsubal Feb 24, 2023
7a73b81
chore: add @types for jest config
fsubal Feb 24, 2023
f69700f
chore: yarn install
fsubal Feb 24, 2023
04134d3
chore: wip
fsubal Feb 24, 2023
9df3372
chore: yarn up react react-dom @types/react @types/react-dom
fsubal Feb 24, 2023
81e9f70
chore: yarn up
fsubal Feb 24, 2023
d11a1ad
chore: add types to pass build
fsubal Feb 25, 2023
882cfb2
chore: make build-storybook pass (some stories are still broken)
fsubal Feb 25, 2023
19f22e1
chore: fix storybook (wip)
fsubal Feb 25, 2023
6d51396
Merge branch 'try-pnp' of github.com:pixiv/charcoal into try-pnp
fsubal Feb 25, 2023
fb4625c
Merge branch 'main' into try-pnp
fsubal Feb 25, 2023
d0f4391
chore: fix
fsubal Feb 25, 2023
89b1f39
chore: ignore pnp
fsubal Feb 25, 2023
0688094
chore: fix lint
fsubal Feb 25, 2023
17f9d71
chore: react 18
fsubal Feb 25, 2023
b001137
chore: use node_modules when measuring bundle size
fsubal Feb 25, 2023
cc786e6
chore: use [email protected]
fsubal Feb 25, 2023
097f02a
chore: ensure yarn install
fsubal Feb 25, 2023
0e01954
chore: clean by install
fsubal Feb 25, 2023
ec0eba8
chore: revert
fsubal Feb 25, 2023
6176fe3
chore: add Required package
fsubal Feb 25, 2023
bfaa7ef
chore: update @storybook/*
fsubal Feb 25, 2023
45d4736
chore: use gitignore
fsubal Feb 26, 2023
2b216ff
chore: try add disable-pnp.sh
fsubal Feb 26, 2023
4736fec
chore: fix reset
fsubal Feb 26, 2023
859fbdf
chore: giving up on cleaning
fsubal Feb 26, 2023
d8db660
chore: make test pass
fsubal Feb 26, 2023
b76b1e5
chore: update vite related modules
fsubal Feb 26, 2023
829ba50
chore: remove unused changes
fsubal Feb 26, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ dist/
node_modules/
__snapshots__/
.yarn/
.pnp.*
/public/
/storybook-static/
/coverage/
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/bundle-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ jobs:
- uses: preactjs/compressed-size-action@v2
with:
build-script: 'build'
clean-script: 'clean'

# compressed-size-action は PnP だとうまく動かない
clean-script: 'disable-pnp-before-build'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

やっても動かなかった…


# パフォーマンス面の計測よりも、誤って変なものを bundle したことを検知したいので圧縮前で比較する
compression: 'none'
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ node_modules/
!.yarn/plugins
!.yarn/sdks
!.yarn/versions
.pnp.*

# artifacts
.DS_Store
Expand All @@ -21,5 +20,3 @@ lerna-debug.log*
.npmrc
*.tsbuildinfo

# editor
.vscode
54,759 changes: 54,759 additions & 0 deletions .pnp.cjs

Large diffs are not rendered by default.

Loading