Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with premultiply alpha and non image based uploading #11221

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: issue with premultiply alpha and non image based uploading #11221

merged 2 commits into from
Jan 23, 2025

Conversation

GoodBoyDigital
Copy link
Member

Description of change

Fixes an issue where gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL was not being set for any upload that is not an image.
Moved this check to outside of the image upload function and into GlTextureSystem.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

github-actions[bot]
github-actions bot reviewed Jan 22, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@Zyie Zyie changed the title fix issue with premultiply alpha and non image based uploading fix: issue with premultiply alpha and non image based uploading Jan 22, 2025
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 22, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25128d0:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jan 23, 2025
@Zyie Zyie added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit 6d8790f Jan 23, 2025
6 checks passed
@Zyie Zyie deleted the bug/alpha-mode-for-non-images branch January 23, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GoodBoyDigital @bigtimebuddy @Zyie