feat: added Texture Options to spritesheet loader #11163
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2c02812:
|
src/spritesheet/spritesheetAsset.ts
Outdated
| const assets = await loader.load<Texture>([imagePath]); | ||
| let assets; | ||
|
|
||
| if (textureOptions) |
There was a problem hiding this comment.
I don't think we even need the if (textureOptions) check here as textureOptions can be null:
replacing the original line
assets = await loader.load<Texture>([imagePath]);
with
assets = await loader.load<Texture>([{ src: imagePath, data: textureOptions}]);
should work!
There was a problem hiding this comment.
It looks like that check is still needed, removing it caused the SVG spritesheet test to fail.
I could modify the SVG script to fix that issue but I don't know if that's in the scope of this PR, what are your thoughts?
|
I've added a test for checking the texture options. |
bigtimebuddy
added
the
✅ Ready To Merge
Description of change
I've added the ability to set TextureOptions on sprites loaded via a spritesheet, as outlined in this Feature Request: #11148
Pre-Merge Checklist
npm run lint)I was having difficulty with the test suite but I tested my changes locally and it functioned as intended with normal and multipacked spritesheets.