Default word-break styling on post comments #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update StatusHashtagService, fix count bug
Update changelog
Remove deprecated profile following/followers
Update FollowController, fix private account bug
Cache ProfileController
Update ComposeModal and Profile components
Update DiscoverController, limit Loops to local only posts
trwnh
approved these changes
Sep 13, 2019
dansup
approved these changes
Sep 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my eye, it appears
word-break: break-allgives jarring word breaks at least for Latin alphabet languages. Removing it seems to smooth things over.If the existing pseudo-justified text feel is desirable, I could add
text-align: justify;(see last screenshot).Current
Proposed change, as written
Proposed change + justified text