Offload the work to a calling thread when using blocking streaming instead of creating a new thread #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivovarit
force-pushed
the
save-threads-when-streaming
branch
from
2af520b to
d84d695
Compare
pivovarit
force-pushed
the
save-threads-when-streaming
branch
from
d84d695 to
c16e64c
Compare
pivovarit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever using one of the factories returning
Stream<T>, the internal dispatcher creates an extra internal thread to orchestrate the processing.However, this is not necessary since the calling thread could perform the same job. For now, it just blocks and waits for the results.