Add pks-login command to Hammer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requires the API for PKS (configurable in OpsManager) to be in Env file
edwardecook
suggested changes
Aug 14, 2019
There was a problem hiding this comment.
@gmrodgers other than the comments I've added I'd say this looks pretty good.
I agree that this ends up looking very similar to hammer cf-login maybe a future optimisation would be to merge some of that code. Also as we have spoken about previously it might be nice to see if pulling the pks api url via om.
|
@gmrodgers Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
edwardecook
approved these changes
Aug 29, 2019
|
@gmrodgers Thank you for signing the Contributor License Agreement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new command for logging into PKS environments. The only new required field in the environment file is the PKS API URL. I put in the URL as otherwise, I would need to differentiate between the staged URL and the templated one (the field is configurable in Opsman). Thoughts/Comments welcome. The structure is very similar to cf-login (some would say a copy-pasta)...