Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go15VendorExperiment: Detect go only if vendor includes go files #723

Conversation

forelabs
Copy link
Contributor

I don't think it is necessary to detect Go15VendorExperiment when there are go files in the project but no go files in the vendor folder. We do have this case because we have a little tiny go script in scripts folder but our default vendor rails folder. And there should only be vendor go dependencies if there are go files in the vendor folder I believe.

This adjustment will solve this issue we have in one project and keep the functionality in another where we have go files and a go vendor folder.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@xtreme-shane-lattanzio xtreme-shane-lattanzio merged commit 204798c into pivotal:master May 11, 2020
@forelabs forelabs deleted the package_managers/go-15-vendor-experiment-detection-fix branch May 13, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants