[FIXED] Handle log file names created with whitespaces and slashes

- Replace whitespace characters with underscore and remove slashes for log file name generation

[finish #161925871]

Signed-off-by: Li Tai <[email protected]>

lib/license_finder/package_manager.rb

@@ -120,7 +120,11 @@ def log_errors(stderr)
 
     def log_to_file(contents)
       FileUtils.mkdir_p @log_directory
-      log_file = File.join(@log_directory, "prepare_#{self.class.package_management_command || 'errors'}.log")
+
+      # replace whitespace with underscores and remove slashes
+      log_file_name = self.class.package_management_command&.gsub(/\s/, '_')&.gsub(/\//,'')
+      log_file = File.join(@log_directory, "prepare_#{log_file_name || 'errors'}.log")
+
       File.open(log_file, 'w') do |f|
         f.write("Prepare command \"#{self.class.prepare_command}\" failed with:\n")
         f.write("#{contents}\n\n")

spec/lib/license_finder/package_manager_spec.rb

@@ -137,6 +137,20 @@ module LicenseFinder
             expect { subject.prepare }.to raise_error(prepare_error)
             expect(File.exist?(File.join(log_directory, 'prepare_foobar.log'))).to be_truthy
           end
+
+          context 'when prepare command has whitespaces and slashes in it' do
+            before do
+              allow(described_class).to receive(:package_management_command)
+                                          .and_return('mono /usr/local/bin/nuget.exe')
+            end
+
+            let(:log_file_path) { File.join(log_directory, 'prepare_mono_usrlocalbinnuget.exe.log') }
+
+            it 'creates log files with whitespaces replaced by underscores and slashes removed' do
+              expect { subject.prepare }.to raise_error(prepare_error)
+              expect(File.read(log_file_path)).to eq error_msg
+            end
+          end
         end
 
         context 'with prepare_no_fail' do