listSync

[jasonkhanlar]

I am not able to use await cowsay.list(function(nothing, cowfiles) { return cowfiles; }) in my code, but with this change, await cowsay.listSync() returns the data.

[piuccio]

What version of node do you use? I'd like to fix cowsay.list to return a Promise, it seems weird that you have to await a Sync() function.

Btw, because list takes a callback, you can also call

const util = require('util');
const list = util.promisify(cows.list);

await list();

[jasonkhanlar]

Oh, I was wondering about that (the list() function and listSync() function was a bit confusing to me).

I was going to rewrite the list() function to return a promise, but then I noticed and tried the listSync() function, which worked for me.

Since you mention that, I'll go ahead and submit a pull request to make list() return a promise. I am using Node v11.0.0 (previously v10.12.0) in an Archlinux environment.

[jasonkhanlar]

See #44

[piuccio]

We don't need listSync now that list returns a promise, you can wait on that. I'll release a new version once the new cows are merged