Use ActiveSupport::Digest when available #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this PR could be reviewed? |
|
@pitr any chance this could get few minutes of your time for review and new release? This patch unblocks using this gem in environments with more strict security constraints (for which FIPS stands for). |
|
@pitr 5 minutes of your time with reviewing this few lines of code and releasing new release would make few people's live easier that they are right now. Quite easy way to enhance ones karma :) |
iNecas
added a commit
to iNecas/foreman-packaging
that referenced
this pull request
Oct 1, 2018
Add patch to enable running in FIPS mode. The patch was sent to upstream a while ago (pitr/angular-rails-templates#158), but the maintainers were not responsive to get this in and released. Threfore, we need to provide this patch during packaging.
iNecas
added a commit
to iNecas/foreman-packaging
that referenced
this pull request
Oct 1, 2018
Add patch to enable running in FIPS mode. The patch was sent to upstream a while ago (pitr/angular-rails-templates#158), but the maintainers were not responsive to get this in and released. Threfore, we need to provide this patch during packaging.
4 tasks
iNecas
added a commit
to iNecas/foreman-packaging
that referenced
this pull request
Oct 1, 2018
Add patch to enable running in FIPS mode. The patch was sent to upstream a while ago (pitr/angular-rails-templates#158), but the maintainers were not responsive to get this in and released. Threfore, we need to provide this patch during packaging.
ekohl
pushed a commit
to theforeman/foreman-packaging
that referenced
this pull request
Oct 1, 2018
Add patch to enable running in FIPS mode. The patch was sent to upstream a while ago (pitr/angular-rails-templates#158), but the maintainers were not responsive to get this in and released. Threfore, we need to provide this patch during packaging.
mathieujobin
approved these changes
Dec 17, 2019
|
please fix the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on ActiveSupport::Digest class introduced in Rails 5.2. This is needed when running in FIPS-compatible environments where MD5 hash isn't available.