Use Clojure resolve to resolve symbols in clj #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisetheridge
force-pushed
the
master
branch
from
096e65d
to
bb1c6cf
Compare
chrisetheridge
changed the title
roman01la
reviewed
Feb 9, 2023
| (assoc v :source %)))))] | ||
| (let [resolve-fn (if (uix.lib/cljs-env? env) | ||
| ana/resolve-var | ||
| resolve) |
There was a problem hiding this comment.
would be good to add a basic test for the linter running on JVM, wdyt?
There was a problem hiding this comment.
Yeah nice idea. Is it fine if the failing cases just crashes the tests? There's no is-not-thrown? in Clojure test, and it felt quite heavy adding it just for this case
There was a problem hiding this comment.
Since all linters are throwing, it would be actually great to have such utility! We'll use for other tests as well
There was a problem hiding this comment.
Okay cool, I will add it!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #90