propagate rules of hooks check to account for nesting

core/src/uix/linter.clj

@@ -200,8 +200,8 @@
   [expr & {:keys [in-branch? in-loop?]
            :or {in-branch? *in-branch?*
                 in-loop? *in-loop?*}}]
-  (binding [*in-branch?* in-branch?
-            *in-loop?* in-loop?]
+  (binding [*in-branch?* (or *in-branch?* in-branch?)
+            *in-loop?* (or *in-loop?* in-loop?)]
     (clojure.walk/prewalk
      (fn [form]
        (cond

core/test/uix/linter_test.clj

@@ -254,6 +254,12 @@
       (is (str/includes? out-str (str :uix.linter/hook-in-loop)))
       (is (str/includes? out-str "React Hook (uix.core/use-effect (fn [])) may be executed more than once.")))
 
+    (testing "should fail on hook call in nested branch or loop"
+      (is (str/includes? out-str (str :uix.linter/hook-in-branch)))
+      (is (str/includes? out-str (str :uix.linter/hook-in-loop)))
+      (is (str/includes? out-str "React Hook (uix.core/use-effect (fn [] \"nested condition\")) is called conditionally."))
+      (is (str/includes? out-str "React Hook (uix.core/use-effect (fn [] \"nested loop\")) may be executed more than once.")))
+
     (testing "should fail on missing key in a loop"
       (is (str/includes? out-str (str :uix.linter/missing-key)))
       (is (str/includes? out-str "UIx element is missing :key attribute, which is required"))

core/test/uix/linter_test.cljs

@@ -49,6 +49,12 @@
   (for [x []]
     (uix.core/use-effect (fn []))))
 
+(defui test-nested []
+  (when false
+    (or (uix.core/use-effect (fn [] "nested condition")) 1))
+  (loop []
+    (loop [x (uix.core/use-effect (fn [] "nested loop"))])))
+
 (defui test-missing-key []
   (for [x []]
     ($ :div.test-missing-key {} x))