Fix: Extended the homebrew Httplib Nofallback Workaround to Linux #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per PR pistacheio#1270, "Enable use of subproject httplib in macOS despite nofallback", the same workaround is now applied in Linux also, so Homebrew in Linux (aka Linuxbrew) can build Pistache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
- Coverage 76.99% 76.01% -0.98%
==========================================
Files 57 60 +3
Lines 7429 9899 +2470
==========================================
+ Hits 5720 7525 +1805
- Misses 1709 2374 +665 ☔ View full report in Codecov by Sentry. |
kiplingw
added
portability
dependencies
|
Looks fine to me, @dgreatwood. If nothing new breaks in CI after the runners are done, feel free to merge. Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR #1270, "Enable use of subproject httplib in macOS despite nofallback", the same workaround is now applied in Linux also, so Homebrew in Linux (aka Linuxbrew) can build Pistache.