Skip to content

Commit

Permalink
Create separate compression-specific layer to enable writing gzipped …
Browse files Browse the repository at this point in the history
…files. Fix #91 (#131)

* First working version

* Python 2.6 compatibility.

Gzip functionality broken in 2.6 because gzip tries to seek around the
file, which is not possible.

* implement separate s3 module

* minor update to S3 subsystem

* integrating new S3 subsystem into smart_open_lib.py

* work around absense of logging.NullHandler in Py2.6

* add docstrings for constants

* pass kwargs to S3 reader/writer constructors

* disable some verbose log statements

* wrap GzipFile in a closing for Py2.6

* get rid of unused imports

* be explicit about bytes vs str for Py3 compatibility

* disabling unsecured mode unit tests

* work around absence of unittest.skip in Python 2.6

* fix fout -> fin in tests

* read/write in binary mode when working via a codec

* get rid of is_gzip function

* fixup for be3bbb3

* bring back tests that "disappeared" during the rebase

* Work around Python 2.6 problem on Travis CI

AttributeError: 'module' object has no attribute 'test_smart_open'

* more "missing" tests

* Fix missing import

* s/_LOGGER/logger/g

* simplify null log handler code, no more Py2.6

* add pass statement to empty function
  • Loading branch information
mpenkov authored and menshikh-iv committed Oct 26, 2017
1 parent ec130ca commit 5f3b6fa
Show file tree
Hide file tree
Showing 7 changed files with 999 additions and 909 deletions.
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ def read(fname):
'boto >= 2.32',
'bz2file',
'requests',
'boto3'
],

tests_require=[
'mock',
'moto==0.4.31',
'responses',
'unittest2'
],


Expand Down
132 changes: 0 additions & 132 deletions smart_open/gzipstreamfile.py

This file was deleted.

Loading

0 comments on commit 5f3b6fa

Please sign in to comment.