Improve Dynamic Topic Model (DTM) documentation #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Oct 24, 2019
|
@piskvorky, I guess this should be more succinct description of this variable? Thanks! |
|
Yes, much better, thanks! |
|
@piskvorky, no problem at all! Anything else require on my side? Thanks. |
|
I don't think so. @mpenkov will be with you presently, to review and merge. Thanks for your patience :) |
piskvorky
changed the title
|
OK, merged. Thank you for your contribution @joelowj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make correction for the datatype for top_chain_var from int to float & updated the documentation on the description of the variable.
Fixes #2637.