-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random_seed
to LdaMallet
#2153
Merged
menshikh-iv
merged 17 commits into
piskvorky:develop
from
ChrisPalmerNZ:mallet-random-seed
Jan 10, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
75c25ee
added random_seed parameter to ldamallet wrapper
ChrisPalmerNZ 1bfaf48
added load for backwards compatibility
ChrisPalmerNZ 2ca085c
fix random_seed evaluation for PEP8 best practice
ChrisPalmerNZ 645863c
Various PEP8 compliance fixes
ChrisPalmerNZ d8e0f54
PEP8: Removed white space from blank lines
ChrisPalmerNZ 53182a0
Added tests for random_seed parameter in ldamallet wrapper
ChrisPalmerNZ 6b2d52b
test_random_seed - test all docs in corpus
ChrisPalmerNZ a5db1df
Added additional blank line after class declaration
ChrisPalmerNZ 3ef309f
PEP8 formatting changes only
ChrisPalmerNZ a6af553
Merge remote-tracking branch 'upstream/develop' into mallet-random-seed
menshikh-iv 53136a1
fix pep8
menshikh-iv 0b3d7aa
use 0 as default seed (according to Mallet doc) + pin seed for infere…
menshikh-iv 7fa5069
make seed test strict
menshikh-iv b001cd3
remove useless test
menshikh-iv f3bd927
remove not used data
menshikh-iv a1e73b6
fix typo
menshikh-iv 86ede21
fill random_seed=0 in load
menshikh-iv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define custom
load
functions for old mallet models (without this option), see an example https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/tfidfmodel.py#L348-L355There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check I have coded and placed this correctly... Should I include logging as in the example?
Training with random_seed - what is required there?