Add gensim.models.BaseKeyedVectors.add_entity method for fill KeyedVectors in manual way. Fix #1942
#1957
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -154,6 +154,19 @@ def get_vector(self, entity): | |
| else: | ||
| raise KeyError("'%s' not in vocabulary" % entity) | ||
|
|
||
| def add(self, entity, weights): | ||
| """Accept an entity specified by string tag and vector weights as 1D numpy array with shape (`vector_size`,). | ||
|
There was a problem hiding this comment. Please use numpy-style docstrings |
||
| If `entity` is already in vocabulary, the call of method has no effect. | ||
| """ | ||
| entity_id = len(self.vocab) | ||
| if entity in self.vocab: | ||
| logger.warning("duplicate entity '%s' in vocab, keeping old vector", entity) | ||
| return | ||
|
|
||
| self.vocab[entity] = Vocab(index=entity_id, count=1) | ||
| self.vectors = vstack((self.vectors, weights)) | ||
| self.index2entity.append(entity) | ||
|
|
||
| def __getitem__(self, entities): | ||
| """ | ||
| Accept a single entity (string tag) or list of entities as input. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's about re-using this function in (this is duplication right now from https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/utils_any2vec.py#L182)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, need to add tests to check this functionality:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menshikh-iv
About reusing this function:
It's a bit difficult because in this function
vstackis used to append new word vector toself.vectors, whileadd_wordin utils_any2vec createsvectorsarray at first (https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/utils_any2vec.py#L180) and then it just inserts vectors into it (https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/utils_any2vec.py#L197).While it's possible to follow DRY here, the interface of
BaseKeyedVectors.add()method will be more complicated (or I can change the logic inutils_any2vec-- not to createvectors = np.zeros(...)but append each word to the array, but it could decrease the performance ofload_word2vec_formatfunction).If some of these two options is okay, I'll implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, thanks for suggestion, let's stay it as is.