refactor syn0 initialization #1799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any suggestion or roadmap for supporting memmap? |
|
@stegben can you add more motivation, why this needed / useful (link to related issues if exists)? |
|
Note that there's some bigger refactoring on the way via #1777, which may change the name of |
|
ping @stegben |
|
I close this PR because it looks abadoned. |
|
Needs better motivation / use-case description. Whom does this help and how? AFAICS, memmap doesn't help if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I slightly refactor the initialization of
syn0ofKeyedVectorsin order to support memmap in the future (if possible).