Add preprocessing step to remove \n from the text before summarizing. Fix 1575. #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmarize Fixes issue piskvorky#1575. No tests were written
menshikh-iv
changed the title
|
Hi @diegospd, please look at broken test, fix it and I'll merge your code. |
|
Ping @diegospd, what's status of current PR? |
|
I close this PR because it looks abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #1575
_clean_text_by_sentencescannot properly handle\nin the middle of sentences. This PR adds a preprocessing step to remove them before doing anything else.Fixes issue #1575.
No tests were written