-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocvecsArray getitem int64 bug #1231
Comments
Why? Do you have an example where the chabge works better? Does the change still support indexed-lookup of string doctags? |
it is because index here may be the numpy.int64 type, and the code here will hurt the indexed-lookup of string doctag, so maybe add a addition compare is ok, like:
|
I see. A PR with a test for the new case this enables, & the fix, would be welcome. |
bogdanteleaga
added a commit
to bogdanteleaga/gensim
that referenced
this issue
Mar 31, 2017
bogdanteleaga
added a commit
to bogdanteleaga/gensim
that referenced
this issue
Apr 29, 2017
tmylk
pushed a commit
that referenced
this issue
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
should be
The text was updated successfully, but these errors were encountered: