Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crum] Non-media Content (including Appendices) should Be Viewable in a Single GSheet #78

Closed
pishoyg opened this issue Jul 29, 2024 · 1 comment
Closed

[Crum] Non-media Content (including Appendices) should Be Viewable in a Single GSheet #78

pishoyg opened this issue Jul 29, 2024 · 1 comment
Labels
architect How: Planning and design user Why: User convenience
Milestone
Crum: Backlog / I...

Comments

@pishoyg
Copy link
Owner

pishoyg commented Jul 29, 2024 •
edited
Loading

We have the following types of appendices:

  • Dawoud pages
  • Editor's Notes
  • Override types (yet to be supported)

It should be possible to view all of them in a single sheet, to minimize confusion, and so you can have a single source of truth (or destination of truth) for all data.
The same gsheet should include Marcion's data.
@pishoyg pishoyg added p3 and removed p3 labels Jul 30, 2024
@pishoyg pishoyg added this to the Crum Pipeline Improvements milestone Aug 4, 2024
This was referenced Aug 4, 2024
Closed
Open
Closed
@pishoyg pishoyg added the architect How: Planning and design label Aug 4, 2024
@pishoyg pishoyg mentioned this issue Aug 5, 2024
Closed
@pishoyg pishoyg added user Why: User convenience and removed p2 labels Aug 8, 2024
This was referenced Aug 9, 2024
Closed
Closed
@pishoyg
Copy link
Owner Author

pishoyg commented Aug 14, 2024

We need to combine data for our Dawoud pages. We could inspect them manually, or we could just let all nonempty entries in one column overwrite the other.

@pishoyg pishoyg changed the title [Crum] Non-media Content (including Augmentations) should Be Viewable in a Single GSheet [Crum] Non-media Content (including Appendices) should Be Viewable in a Single GSheet Aug 14, 2024
@pishoyg pishoyg changed the title [Crum] Non-media Content (including Appendices) should Be Viewable in a Single GSheet [Crum] Non-media Content (including Augmentations) should Be Viewable in a Single GSheet Aug 14, 2024
@pishoyg pishoyg changed the title [Crum] Non-media Content (including Augmentations) should Be Viewable in a Single GSheet [Crum] Non-media Content (including Appendices) should Be Viewable in a Single GSheet Aug 14, 2024
pishoyg added a commit that referenced this issue Aug 14, 2024
@pishoyg
[#78][Crum/Augmentations] Dawoud Pages and Notes Live in the Same Sheet.
fb99835 
This is it (if you can access it):

https://docs.google.com/spreadsheets/d/1OVbxt09aCxnbNAt4Kqx70ZmzHGzRO1ZVAa2uJT9duVg/edit.

You can curl the full URL, but you probably can't view it using this URL
unless your Gmail account has been granted access to it.
pishoyg added a commit that referenced this issue Aug 15, 2024
@pishoyg
[#78,#123][Crum] Store a Local Copy Appendices in a Single TSV.
d5d9a7a 
This is a followup to fb99835.
pishoyg added a commit that referenced this issue Aug 15, 2024
@pishoyg
[#177,#78][Stats/Crum] Add a Stats for the Number of Notes.
687a7bd
pishoyg added a commit that referenced this issue Aug 15, 2024
@pishoyg
[#177,#78][Stats] Add Stats for Crum Notes, and LOC per Language.
6d347b7
pishoyg added a commit that referenced this issue Aug 15, 2024
@pishoyg
[#177,#78][Stats] Add Stats for Crum Notes, and LOC per Language.
63cd570
@pishoyg pishoyg mentioned this issue Aug 15, 2024
Open
@pishoyg pishoyg closed this as completed Aug 15, 2024
pishoyg added a commit that referenced this issue Aug 17, 2024
@pishoyg
[#141,#193,#78] Restore the Script to Download a Sheet.
9e86fd2 
This will make it possible to keep the data private. The current setup,
which uses `curl`, forces us to make the data public.

Retrieve `JSON_KEYFILE_NAME` from the environment variables.
pishoyg added a commit that referenced this issue Sep 5, 2024
@pishoyg
[#78,#183,#213][Crum/Appendices] Use Python. Validate in Pre-commit.
3dbcffc 
- Introduce a new script,
  `dictionary/marcion.sourceforge.net/appendices.py`, that is
  responsible for all the appendices-related actions. Currently, the
  actions are downloading the sheets into the local mirrors, and
  validating the content.
- The script replaces the following:
  - The Makefile recipe that downloads the sheets and performs some
    basic validation. The recipe has been replaced with a new recipe
    that simply calls the script mentioned above.
  - The logic in the Flashcards pipeline doesn't need to perform any
    validation, it can take the integrity of the data for granted thanks
    to the pre-commit hooks.

Python is more versatile and suitable for this use case. This
definitely didn't belong in a Makefile recipe!
This is also consistent with the pattern that we have followed for Crum
images.
@pishoyg pishoyg added this to coptic Sep 11, 2024
@pishoyg pishoyg mentioned this issue Feb 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architect How: Planning and design user Why: User convenience
Projects
coptic
Archived in project
Milestone
Crum: Backlog / Ideas
Development

No branches or pull requests
1 participant
@pishoyg