Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle mouse events when leaving or entering the sidebar #2008

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

klemens
Copy link
Contributor

@klemens klemens commented Aug 24, 2018

This new implementation for mouseover and mouseout is based on the relatedTarget property of the mouse event. It can be used to detect if an element is entered from a child, parent or from outside the window. The same is true for leaving elements.

This means we no longer have to keep track which element was entered or left last and directly send events without a timeout.

This mostly fixes #1992.

…oor#1992

This new implementation for mouseover and mouseout is based on the
relatedTarget property of the mouse event. It can be used to detect
if an element is entered from a child, parent or from outside the
window. The same is true for leaving elements. This means we no longer
have to keep track which element was entered or left last and directly
send events without a timeout.
@piroor piroor merged commit a287c50 into piroor:master Aug 27, 2018
@piroor
Copy link
Owner

piroor commented Aug 27, 2018

Thanks! I didn't know how to use event.relatedTarget.
https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/relatedTarget

@klemens klemens deleted the mouse-events branch August 27, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tab-mouseout event fired while still on tab
2 participants