Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to detect duplicated tabs on Firefox 89 #2845

Closed
piroor opened this issue Mar 30, 2021 · 12 comments
Closed

Failed to detect duplicated tabs on Firefox 89 #2845

piroor opened this issue Mar 30, 2021 · 12 comments
Labels
Firefox-issue bug of Firefox itself stale no reaction got for a long term

Comments

@piroor
Copy link
Owner

piroor commented Mar 30, 2021

After logging on Nightly 89.0a1 I've realized that TST cannot detect duplicated tabs anymore. The detection method still works on Firefox 87.0, so something change triggers this problem. Hmm...

@piroor
Copy link
Owner Author

piroor commented Mar 30, 2021

On Nightly 89.0a1, browser.sessions.getTabValue for a newly opened tab sometimes fails. It looks required to wait until its initialization is finished - on my case 100ms is enough safe but it may be different on some environments.

@piroor
Copy link
Owner Author

piroor commented Mar 30, 2021

@piroor
Copy link
Owner Author

piroor commented Mar 30, 2021

On my case 400msec delay is required for 100% successful detection. 350msec delay just successes with 80% probability. This delay is painfully large...

@piroor
Copy link
Owner Author

piroor commented Mar 30, 2021

1701900 - sessions.getTabValue() requires too large delay to get expected value for a duplicated tab
https://bugzilla.mozilla.org/show_bug.cgi?id=1701900

@irvinm
Copy link
Contributor

irvinm commented May 3, 2021

@piroor do you want to add the label "bug of Firefox itself" for tracking purposes?

@piroor piroor added the Firefox-issue bug of Firefox itself label May 3, 2021
@piroor
Copy link
Owner Author

piroor commented May 3, 2021

Not only around duplicated tabs, this change of Firefox looks to break tree restoration on the startup.

@piroor
Copy link
Owner Author

piroor commented Aug 8, 2021

I've introduced a change 1f22694 to reduce the side effect I commented at #2845 (comment)

@github-actions github-actions bot added the stale no reaction got for a long term label Aug 25, 2021
Repository owner deleted a comment from github-actions bot Aug 25, 2021
@piroor piroor removed the stale no reaction got for a long term label Aug 25, 2021
@grahamperrin

This comment was marked as off-topic.

@irvinm
Copy link
Contributor

irvinm commented Dec 24, 2021

@grahamperrin, what does this have to do with this issue? It is a reasonable question, but probably better discussed in "Discussions". Auto Tab Discard is likely part of it ... and the "dimmed" tab is likely a "discarded" tab (depends on TST CSS) but many addons implement that feature. The planet\globe just says that the favico isn't available or hasn't been loaded yet.

@grahamperrin

This comment was marked as off-topic.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This issue has been labeled as "stale" due to no response by the reporter within 1 year (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

@github-actions github-actions bot added the stale no reaction got for a long term label Aug 9, 2022
@github-actions
Copy link

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefox-issue bug of Firefox itself stale no reaction got for a long term
Projects
None yet
Development

No branches or pull requests

3 participants