do not try to resize block volumes #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
fix-block-resize
branch
from
a746771 to
f0939e3
Compare
Block volumes cannot be resized, so there is no point in even attempting it. An attempt would fail because it could not determine the FS one the volume, as there likely isn't any. A retry would then succeed as there is an earlier check if we need to mount at all. The fix is to rearrange the logic to only attempt to resize filesystem volumes. While at it, also remove the deprecated "IsNotMountPoint". The double negative was getting confusing in any case. Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
fix-block-resize
branch
from
f0939e3 to
86689ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block volumes cannot be resized, so there is no point in even attempting it. An attempt would fail because it could not determine the FS one the volume, as there likely isn't any. A retry would then succeed as there is an earlier check if we need to mount at all.
The fix is to rearrange the logic to only attempt to resize filesystem volumes.
While at it, also remove the deprecated "IsNotMountPoint". The double negative was getting confusing in any case.