Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes + improvements with respect to recent caching changes #272

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

WanzenBug
Copy link
Member

  • Upgrading golinstor to improve cache invalidation when creating/restoring backups
  • Fix two-primaries special case resulting in unexpected errors
  • Sanity check the we actually forward a device name to the csi-node component
  • Reduce resouce cache timeout to below default provisioning time to reduce wait time for provisioning

WanzenBug added 4 commits June 4, 2024 14:17
This was left over after experiments moved the volume context to
the publish context.

Signed-off-by: Moritz Wanzenböck <[email protected]>
This is noticably shorter then the default provisioning timeout of 1m, so
if we for example wait for some resource that get ready, we should be able to
see the results within a single provisioning run.
@WanzenBug WanzenBug requested a review from rck June 4, 2024 13:32
Copy link
Member

@rck rck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rck rck merged commit 26af8d9 into master Jun 5, 2024
4 checks passed
@rck rck deleted the fix-caching branch June 5, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants