Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement L2L backup shipping #259

Merged
merged 1 commit into from
Apr 25, 2024
Merged

implement L2L backup shipping #259

merged 1 commit into from
Apr 25, 2024

Conversation

WanzenBug
Copy link
Member

Fill in the missing implementation for backup shipping to another LINSTOR cluster. Because we can't "wish" for a specific snapshot name, we store a mapping of requested snapshot name to actually taken snapshot name in a special LINSTOR KV.

Other than that, it is simply a matter of wiring up the necessary plumbing.

This currently cannot restore a backup once it is shipped and the local snapshot deleted, and it is unlikely that such a thing could be implemented, as LINSTOR does not support downloading a snapshot once shipped.

@WanzenBug WanzenBug force-pushed the l2l-shipping branch 4 times, most recently from fe28885 to 64eafe0 Compare April 22, 2024 06:10
Fill in the missing implementation for backup shipping to another LINSTOR
cluster. Because we can't "wish" for a specific snapshot name, we store a
mapping of requested snapshot name to actually taken snapshot name in
a special LINSTOR KV.

Other than that, it is simply a matter of wiring up the necessary plumbing.

This currently cannot restore a backup once it is shipped and the local
snapshot deleted, and it is unlikely that such a thing could be implemented,
as LINSTOR does not support downloading a snapshot once shipped.

Signed-off-by: Moritz Wanzenböck <[email protected]>
@WanzenBug WanzenBug marked this pull request as ready for review April 22, 2024 07:26
@WanzenBug WanzenBug requested a review from rck April 25, 2024 06:56
Copy link
Member

@rck rck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rck rck merged commit 531666d into master Apr 25, 2024
5 checks passed
@rck rck deleted the l2l-shipping branch April 25, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants